search

markwal / GPX

Gcode to x3g conversion post processor
GNU General Public License v2.0
98 stars 80 forks source link

Use double literal when calculating dda_rate #11

Closed hyperair closed 8 years ago

hyperair commented 8 years ago

This fixes an issue where dda_rate gets calculated off-by-one when compiled with -O2 on Debian i386:

--- lint.txt    2016-04-13 21:56:39.645223310 +0800
+++ tests/lint.txt      2016-04-02 13:27:31.000000000 +0800
@@ -13,7 +13,7 @@
 12: (155) Move to (889, 889, 4000, -96, 0), DDA rate 3849, A, B relative, distance 34.641018 mm, feedrate*64 1066 steps/s
 13: (150) Set build percentage 1%, reserved 0
 14: (149) Display message, options 0x02, position (0, 0), timeout 0 s, message "G1 - coord move-f"
-15: (155) Move to (889, 889, 4000, -97, 0), DDA rate 2559, A, B relative, distance 1.000000 mm, feedrate*64 1706 steps/s
+15: (155) Move to (889, 889, 4000, -97, 0), DDA rate 2560, A, B relative, distance 1.000000 mm, feedrate*64 1706 steps/s
 16: (149) Display message, options 0x02, position (0, 0), timeout 0 s, message "G4 - dwell"
 17: (133) Dwell for 1000 milliseconds
 18: (149) Display message, options 0x02, position (0, 0), timeout 0 s, message "G10 - set offsets"