search

markwatkinson / luminous

Accurate and powerful syntax highlighting library
http://luminous.asgaard.co.uk
GNU Lesser General Public License v2.1
50 stars 5 forks source link

Laravel / packagist cache locations #28

Open PWA-GouldA opened 10 years ago

PWA-GouldA commented 10 years ago

Issue

When using luminous within Laravel 4, the cache folder does not use the default Laravel storage folder for caching. This means that luminous requires another location to be made read/write and thus possibly open up to 'hack'.

Resolution

Check to see if luminous within laravel, and if so, point the cache files at the location storage/luminous.

markwatkinson commented 10 years ago

I'm not sure that Luminous itself should be checking to see whether it is within Laravel specifically, but a configurable cache directory sounds sensible to me. Will that fix the problem?

PWA-GouldA commented 10 years ago

That would be a good fix. I've got to learn more about packages and writing them, once I have got a bit more under my belt I may be able to contribute something to your project in a way that would "automagically" point at the correct cache location in the likes of Laravel.

markwatkinson commented 10 years ago

Ok - configurable cache directory looks like a simple (and sensible) change, so I'm happy to do that (maybe this weekend if I get chance). When I have time, I will check out Laravel and see if there's any obvious improvements I see for how Luminous could sit inside it (in a fairly agnostic sort of way).

If you do wish to make any contributions, please feel free :)