search

markwatkinson / luminous

Accurate and powerful syntax highlighting library
http://luminous.asgaard.co.uk
GNU Lesser General Public License v2.1
51 stars 5 forks source link

ANSI formatter should use more compatible xterm256color escape codes #36

Closed J5lx closed 9 years ago

J5lx commented 9 years ago

Currently the ANSI formatter uses the 'closest match' escape codes from ISO-8613-3 which are supported by very few terminal emulators (only GNOME Terminal, xterm and Konsole IIRC). Instead, the formatter should rely on nothing but the more compatible xterm256color codes by default. However those codes would require lots of expensive color distance calculations, so 'closest match' support should still be available through an option.

I’m going to work on this myself very soon.

J5lx commented 9 years ago

At first I referred to ISO-8613-3 as a whole instead of the 'closest match' codes in particular and to ECMA-48 instead of the xterm256color codes. However, actually only those 'closest match' codes are rarely supported, while the ones commonly referred to as xterm256color codes are supported by pretty much every common terminal emulator. This has now been corrected in the original post.