search

markweirath / big-brother-bot

Big Brother Bot B3 is a complete and total server administration package for online games. B3 is designed primarily to keep your server free from the derelicts of online gaming, but offers more, much more.
http://www.bigbrotherbot.net
44 stars 32 forks source link

Client disconnect event send non existing CID #47

Closed dahool closed 12 years ago

dahool commented 13 years ago

Why the disconnect event send the cid instead of the client id ?

        self[cid] = None
        del self[cid]
        del client
        self.console.queueEvent(b3.events.Event(b3.events.EVT_CLIENT_DISCONNECT, cid))

I don't see any much sense on this, as we will not have chance to identify the disconnected client.

thomasleveil commented 12 years ago

yep, useless in current state. Would be better to attach the client object to the event

dahool commented 12 years ago

True, or at least client id would be more useful.

thomasleveil commented 12 years ago

e1444c5 was not a fix for this issue but for issue Courgette/big-brother-bot#47

I will now use fully qualified issue names in commit messages to avoid such confusions.

This bug should remain open

thomasleveil commented 12 years ago

now the EVT_CLIENT_DISCONNECT event has the following data associated : data : previously used cid for the disconnected player client : client object for the disconnected player

dahool commented 12 years ago

Nice addition.

thomasleveil commented 12 years ago

now in B3 1.8b2