search

markweirath / big-brother-bot

Big Brother Bot B3 is a complete and total server administration package for online games. B3 is designed primarily to keep your server free from the derelicts of online gaming, but offers more, much more.
http://www.bigbrotherbot.net
44 stars 32 forks source link

Encoding #63

Closed 82ndab-Bravo17 closed 12 years ago

82ndab-Bravo17 commented 13 years ago

These changes seem to cure most of the Encoding/Decoding problems that we were having in COD4 from names having characters >127 in them.

I have made the default encodong latin-1, as that will deal with all other encodings without an error, and setting encoding to None completely messed up all rcon communication, it threw errors for the /xff in the rcon protocol.

There is still the issue of $name in all of the message templates, which I think may be an issue with how those templates are handled by Python, rather than an issue caused by the UTF-8 encoding changes. I cannot test it, but this could be effecting all games that allow characters >127 in their names, except RO2 where I ended up repr() all of the names since I was also dealing with the website encodings.

thomasleveil commented 12 years ago

0 commit in this pull request, should it be closed ?

82ndab-Bravo17 commented 12 years ago

As far as I know the issue with the $name still exists, not quite sure how to deal with it.

And there were some commits in the request when I created it, not sure where they went.....

thomasleveil commented 12 years ago

they might have been merged already ?