marl / jams

A JSON Annotated Music Specification for Reproducible MIR Research
ISC License
186 stars 27 forks source link

Include jams-data as a submodule in the main jams repo? #114

Closed urinieto closed 7 years ago

urinieto commented 8 years ago

I think it would be nice to add a submodule to the jams-data repo inside the this main jams repo.

I recently did this with msaf (look at the datasets folder). I'd be happy to create a PR for this in jams if you find it appropriate.

bmcfee commented 8 years ago

Why? Nothing in jams depends on jams-data.

urinieto commented 8 years ago

So that if you want to have some JAMS files to play around with once you cloned the jams repo, you could simply do it from the jams repo, instead of having to go and clone another repo in another folder.

bmcfee commented 8 years ago

Not sure that's something we really want though. I figure most jams users will install via pip; cloning the repo should really only be for development. That's just my 2 :heavy_multiplication_x: :dollar: / :100: though. Anyone else have opinions?

justinsalamon commented 8 years ago

Not sure I'd include jams-data as part of jams, but perhaps increasing the visibility of jams-data in the jams documentation (e.g. in the readme file) would be a good idea, as it seems many people aren't aware of the repo at all, some even asking about writing parsers that already exist.

bmcfee commented 7 years ago

Any objection to closing this out?

urinieto commented 7 years ago

None from me.