Closed urinieto closed 7 years ago
Why? Nothing in jams depends on jams-data.
So that if you want to have some JAMS files to play around with once you cloned the jams
repo, you could simply do it from the jams
repo, instead of having to go and clone another repo in another folder.
Not sure that's something we really want though. I figure most jams users will install via pip; cloning the repo should really only be for development. That's just my 2 :heavy_multiplication_x: :dollar: / :100: though. Anyone else have opinions?
Not sure I'd include jams-data as part of jams, but perhaps increasing the visibility of jams-data in the jams documentation (e.g. in the readme file) would be a good idea, as it seems many people aren't aware of the repo at all, some even asking about writing parsers that already exist.
Any objection to closing this out?
None from me.
I think it would be nice to add a submodule to the jams-data repo inside the this main
jams
repo.I recently did this with msaf (look at the
datasets
folder). I'd be happy to create a PR for this in jams if you find it appropriate.