bmcfee
commented
7 years ago I've taken the liberty of adding that one here, and alphabetizing the symbol table so we can add to it with some kind of convention going forward.
I don't think it should be alphabetically or lexically ordered. The choice of OrderedDict was intentional, and meant to reflect priority and specificity of the different annotation viz functions when multiple matches are possible. For instance, basically everything is convertible to tag_open, but you wouldn't want to use that viz for things where more precise displays are possible.
I agree that this is not well documented though, so we should improve on that.
The jams.display submodule rocks but I've had to override the
VIZ_MAPPINGsymbol table to use it with different namespaces, e.g.tag_open. I've taken the liberty of adding that one here, and alphabetizing the symbol table so we can add to it with some kind of convention going forward.but!
this might be indicative of something we want to fix in general, and I'm curious to kick it around (here, I guess?). Should a namespace JSON file also specify how it should be visualized? seems like adding this info in two places is a design smell.
also: happy to move this to an issue first.