Open bmcfee opened 6 years ago
Looked into this: the problem is that jupyterlab no longer uses bootstrap, so the CSS classes we used for rendering JAMS objects in juypter notebook are now missing; specifically panels and panel-groups.
This is related to these threads: https://github.com/jupyterlab/jupyterlab/issues/3200 https://github.com/jupyterlab/jupyterlab/issues/2693 . It sounds like the jupyter folks want to expose some common CSS classes for this sort of thing, but it's unclear whether that would include enough functionality to get the nesting/expansion behavior we use currently.
I think we should hold off on fixing this. Jupyterlab seems to be a bit in flux about supporting styled outputs, so any fix we do in the short term would need to be revisited down the road anyway.
Going forward, I think a better long-term solution would be the following:
The above is generally blocked by jams 0.4 (at least) and jupyterlab 1.0, so we can punt it for now.
Probably something changed dramatically in the CSS between jupyter notebook and jupyterlab.
Anyone interested in taking a look at this?