Allow to change the default indentation of the produced JSON.

marl / jams

A JSON Annotated Music Specification for Reproducible MIR Research

ISC License

185 stars 26 forks source link

Allow to change the default indentation of the produced JSON. #210

Open hendriks73 opened 4 years ago

hendriks73 commented 4 years ago

The default is 2, which can lead to fairly large bloat, when considering ten-thousands of JAMS (think global tempo estimates like https://github.com/tempoeval/tempo_eval/tree/main/annotations). Of course one can go the gzip/jamz route, which will create smaller files, but at the price of (easy/casual) editability.

Being able to simple pass indent=None is a compromise. It still allows manual editing, while also reducing size quite a bit.

hendriks73 commented 3 years ago

Closed and re-opened PR to trigger Travis build. Since Master has changed, it should run through this time. The change is trivial.

justinsalamon commented 3 years ago

Lgtm, @bmcfee any comments before I merge and bump the patch version?

bmcfee commented 3 years ago

Lgtm, @bmcfee any comments before I merge and bump the patch version?

LGTM, thanks!

Before bumping the version, I think it's worth combing through open issues and seeing if there's anything else that needs fixing in the short term.