Partial annotation [implements #66 ]

bmcfee commented 9 years ago

Implements #66

bmcfee commented 9 years ago

I've implemented the schema changes as described in #66 . A couple of things to hammer out before merging:

Do we want the time/duration fields to be timedeltas (as in the jamsframe) or plain floats? The latter is simpler and fits with the FileMetadata duration field, but timedeltas would make it fit with jamsframe.
Should we make them required fields? Right now it's either a non-negative number or 'null'. Is this okay with everyone?

bmcfee commented 9 years ago

Since nobody's taking my bait, here's my 2e-2€:

Do we want the time/duration fields to be timedeltas (as in the jamsframe) or plain floats? The latter is simpler and fits with the FileMetadata duration field, but timedeltas would make it fit with jamsframe.

I vote float for simplicity and consistency with file_metadata. (This is a pyjams thing, not a schema thing.)

Should we make them required fields? Right now it's either a non-negative number or 'null'. Is this okay with everyone?

I don't think we should make them required.

If everyone agrees with me on the above, this PR is ready to merge.

justinsalamon commented 9 years ago

:+1:

urinieto commented 9 years ago

Sounds good to me too.

On Mon, Sep 21, 2015 at 7:31 AM, Justin Salamon notifications@github.com wrote:

[image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/marl/jams/pull/67#issuecomment-141999693.

marl / jams

Partial annotation [implements #66 ] #67