marl / openl3

OpenL3: Open-source deep audio and image embeddings
MIT License
452 stars 57 forks source link

Add missing comma to dependencies #88

Closed bmcfee closed 2 years ago

bmcfee commented 2 years ago

This took me a minute to track down, but there was a missing comma in setup.py that was causing my conda environment spec to break.

Without the comma, the dependencies for scikit-image and librosa run together into a single string, so you get "scikit-image >= 0.14.3librosa>=0.7.2" and everything blows up.

auroracramer commented 2 years ago

Good catch!

loisaidasam commented 1 year ago

Gah, this one got me too! Is it possible to get a new pip-installable tag/version with this fix in it?