marl / openl3

OpenL3: Open-source deep audio and image embeddings
MIT License
452 stars 57 forks source link

Clarification on input representation #92

Open alisonbma opened 2 years ago

alisonbma commented 2 years ago

I was just reading through the source code on openl3 > core.py and noticed something in functions (1. _librosa_linear_frontend and 2. _librosa_mel_frontend). It seems librosa.power_to_db() is being used on a magnitude, not power spectrum? Instead should it be using librosa.amplitude_to_db()?