Update `Iterable` import to support Python>=3.3 - Githubissues

marl / openl3

OpenL3: Open-source deep audio and image embeddings

MIT License

461 stars 58 forks source link

Update `Iterable` import to support Python>=3.3 #95

Open Gennadiyev opened 1 year ago

Gennadiyev commented 1 year ago

Whe running with CLI on Python>3.3, an error will be raised:

ImportError: cannot import name 'Iterable' from 'collections' (.../collections/__init__.py)

Cause

Introduced in python 3.3, the previous collections.Iterable is removed.

Potential Fix

Use six to provide an extra compatibility layer over type hints (with collection_abc)
Use the quick fix of a try except block

Commit Info

The latter solution is used for the sake of simplicity.

Tests

(🟢 this commit has no breaking changes and is a minor patch.)