search

marl / pysox

Python wrapper around sox.
BSD 3-Clause "New" or "Revised" License
513 stars 79 forks source link

Replace deprecated imp module with importlib #158

Closed hugovk closed 7 months ago

hugovk commented 1 year ago

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

https://github.com/rabitt/pysox/blob/0a428b88f76c41e93eecbf49bb27b97c7b3f9de7/setup.py#L6

https://github.com/rabitt/pysox/blob/0a428b88f76c41e93eecbf49bb27b97c7b3f9de7/docs/conf.py#L18

lostanlen commented 8 months ago

Hello @hugovk,

With permission from @rabitt I am taking over the maintenance of pysox and prepare a new release (v1.5) on PyPI. I have push access on this repository.

This seems like the most urgent issue since pysox 1.4 no longer runs on the latest version of Python (3.12). Can you please prepare a PR removing the use of imp and replacing it by importlib? Thank you

hugovk commented 8 months ago

Yes, please see PR https://github.com/rabitt/pysox/pull/160.