marlersoft / zigwin32

Zig bindings for Win32 generated by https://github.com/marlersoft/zigwin32gen
MIT License
257 stars 31 forks source link

SC_MANAGER_ALL_ACCESS missing from system.services #7

Open cark opened 3 years ago

cark commented 3 years ago

If I am not mistaken, it's not defined anywhere else in zigwin32 either. I don't see it in the json either, though I might not be squinting enough =)

defined like so in winsvc.h:

#define SERVICE_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED | SERVICE_QUERY_CONFIG | SERVICE_CHANGE_CONFIG | SERVICE_QUERY_STATUS | SERVICE_ENUMERATE_DEPENDENTS | SERVICE_START | SERVICE_STOP | SERVICE_PAUSE_CONTINUE | SERVICE_INTERROGATE | SERVICE_USER_DEFINED_CONTROL)
marler8997 commented 3 years ago

Thanks for the heads up, I've created an issue for this in the metadata repo here: https://github.com/microsoft/win32metadata/issues/637

cark commented 3 years ago

I see that SERVICE_ALL_ACCESS from winsvc.h is also missing. Again not in the json either. No wonder there, it's the same kind of declaration.

#define SERVICE_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED | SERVICE_QUERY_CONFIG | SERVICE_CHANGE_CONFIG | SERVICE_QUERY_STATUS | SERVICE_ENUMERATE_DEPENDENTS | SERVICE_START | SERVICE_STOP | SERVICE_PAUSE_CONTINUE | SERVICE_INTERROGATE | SERVICE_USER_DEFINED_CONTROL)

You might want to hold a bit reflecting this to upstream. I'm (slowly) implementing a windows service, so I may stumble upon some more along the way. Let me know if you'd rather have separate issues instead.