Do not use a dialog to inform that no more match can be found

[CyrilleB79]

Hi again @marlon-sousa

Here is another feature request. The dialog indicating that there is no more match when performiing a search operation is not very nice. It gives you an information, but the only operation is press OK to validate it.

A smoother flow would be to indicate by speech or by a special beep that no match can be found.

There are 2 situation to be tested where this "No match" dialog can appear:

• After pressing OK in the find dialog
• After pressing F3/shift+F3 to find next/previous occurrence

Before using your add-on, I had coded a prototype of this feature; you can find it here.

[CyrilleB79]

Also, do you plan to submit your add-on to the add-on store? That would be appreciated.

[marlon-sousa]

Hello,

PRS are accepted.

The only point worth of noticing is this: when you are at a page using search wrap and you are at the last occurrence at the searched term, a quick beep will be played and you will be placed at the first occurrence of the searched term.

The line where that searched term is located will be read.

If the term not found message follows the same pattern, a user running a fast flow might get confused.

So make sure that:

1. An audio queue such as a beep will be played.
2. A message stating that search term is not found is clearly spoken.
3. No piece of text is read, even though the user keeps focused where they originally were.

[marlon-sousa]

Hello,

Can you outline where I can find the procedures to submit it to the addon store?

Then I can do it.

[CyrilleB79]

Can you outline where I can find the procedures to submit it to the addon store?

Then I can do it.

You can have a look at the submission guide, more specifically the paragraph "Steps to submit an add-on". If you need more help, just let it know.

Regarding the current issue and the other one that I have opened today, I may provide a PR, but not sure to be able to do it soon. So if you or someone else want to tackle it, feel free to do so!

[marlon-sousa]

Hello,

As for submiting the addon, I would need to generate a fixed url, which currently is not supported in my ci schema, because I generate always a named file with included version in the name, which points to a given release.

I will see what can be done about it. If github has a latest alias may be I can use it and name the file always the sane, so that the final url is always the same independently of the release.

Anyways, this will take some time to implement.

[CyrilleB79]

As for submiting the addon, I would need to generate a fixed url, which currently is not supported in my ci schema, because I generate always a named file with included version in the name, which points to a given release.

No, there is no problem with your URLs. You just have to put https://github.com/marlon-sousa/EnhancedFindDialog/releases/download/1.4.1/EnhancedFindDialog-1.4.1.nvda-addon in the field for download URL. And when you make a new version of your add-on, you use the same form to submit the next version to the store.

Just one thing you need to take care is that you must never change the file .nvda-addon pointed by the URL you have given to the store since a checksum is computed at submission time and need to remain the same when people download the add-on.

[thgcode]

A bit related, today I was thinking on another possibility, an optional simpler mode that doesn't display the dialog at all, you start typing and it filters the elements, if the current element fills the search criteria NVDA will repeat it as long as the search term fills the criteria. By pressing the up and down arrow keys, NVDA would cycle for the previous or next element with the find text. But maybe this will require big changes to the browse mode.