marlonfan / coc-phpls

🐭 php language server for coc.nvim
MIT License
212 stars 16 forks source link

Upgrade intelephense to 1.9 #120

Closed lewissteele closed 1 year ago

lewissteele commented 1 year ago

This bumps intelephense up to 1.9 which adds support for PHP 8.1 features like enums:

Peek 2023-04-01 12-33

I've installed onto my local nvim and it works great! :smile:

z0w13 commented 1 year ago

You've added a .yarnrc.yml specifying yarnPath without also committing the yarn version you're referencing to, is yarn 1.0 required or was this on accident:

yarnPath: .yarn/releases/yarn-1.22.19.cjs

this will error when people don't manually grab that yarn release and put it into that folder.

node:internal/modules/cjs/loader:1093
  throw err;
  ^

Error: Cannot find module '/home/zowie/.config/nvim/bundles/repos/github.com/marlonfan/coc-phpls/.yarn/releases/yarn-1.22.19.cjs'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1090:15)
    at Module._load (node:internal/modules/cjs/loader:934:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v19.8.1
marlonfan commented 1 year ago

@z0w13 You are right, I deleted this file when publishing, I will update the code later

marlonfan commented 1 year ago

@z0w13 master's code has been updated to fix this issue

lewissteele commented 1 year ago

Sorry about that, I don't have much experience with yarn, I'm more of an npm man :laughing:

@marlonfan Thanks for fixing it