marlonfan / coc-phpls

🐭 php language server for coc.nvim
MIT License
212 stars 16 forks source link

renaming feature doesn't save modifications #36

Open fabiosal opened 4 years ago

fabiosal commented 4 years ago

Hi, when renaming a variable using nmap <leader>rn <Plug>(coc-rename)

after renaming the various buffers affected by the changes are not saved. I can't get evidence of the modification using git (status)

marlonfan commented 4 years ago

Hi, thanks for the feedback.

I think this is due to the nature of vim. The temporary solution is to add a shortcut save all buffers.

And then I'm going to implement auto save renamed file buffers

gabrielbidula commented 3 years ago

Hi @marlonfan, could you share your shortcut for this while the auto save isn't done? thanks

gabrielbidula commented 3 years ago

Actually, we can just hit :wa on quickfix window to get all files saved.