search

marlonfan / coc-phpls

🐭 php language server for coc.nvim
MIT License
212 stars 16 forks source link

feat(lsp): Add config option to enable/disable diagnostics #54

Closed Pablo1107 closed 4 years ago

marlonfan commented 4 years ago

@Pablo1107 Hi, this PR has conflicts. Is it convenient to solve it?

yaegassy commented 4 years ago

@marlonfan @Pablo1107

Currently, the intelephense.diagnostics.enable setting has been added to the "intelephense".

REF

    "intelephense.diagnostics.enable": {
        "type": "boolean",
        "default": true,
        "description": "Enables diagnostics.",
        "scope": "window"
    },

You don't need to add your own in coc-phpls.

I have created a PR that includes an upgrade of the "intelephense" itself and additional intelephense.diagnostics.enable settings. https://github.com/marlonfan/coc-phpls/pull/67

Pablo1107 commented 4 years ago

@yaegassy that's great, I'll close this PR then.