Ctrl+S opens "save as" popup instead of toggle sidebar

marlosoft / slack-toggle-sidebar

Toggle show or hide Slack's channel sidebar

MIT License

6 stars 3 forks source link

Ctrl+S opens "save as" popup instead of toggle sidebar #4

Closed HugoFerrant closed 4 years ago

HugoFerrant commented 5 years ago

On last public Firefox update (68.0.1 linux 64-bit), the extension's shortcut is overridden by the native CTRl+S for "save as", implying the extension can't be used anymore as there is no fallback shortcut or shortcuts settings.

peter-lyons-kehl commented 5 years ago

Hi John @factorin-j,

Thank you for Slack Toggler SideBar.

I confirm that Ctrl+S stopped working on Linux as Hugo described above. Firefox v. 68.0.1, but also 70 alpha - so it's their intention.

You may be interested in https://support.mozilla.org/en-US/kb/manage-extension-shortcuts-firefox. Chrome also has an API that is similar. Would you consider that, please?

HugoFerrant commented 4 years ago

this might help too : https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands