marlove / react-native-geocoding

MIT License
208 stars 54 forks source link

Fixes for the typescript declaration file #34

Closed Brumor closed 3 years ago

Brumor commented 4 years ago

Hey, I really like your project, it's very useful, however I had a lot of incoherence with typescript and the documentations, so I decided to take a look at the declaration file and it needed some fixing, the declaration file was stating that Geocoder is a class when it is actually an object (doesn't have a constructor, etc.). So I went ahead and rewrote it using the results I got with different inputs (I tested with an address as a string and an object with lat and lng)

This way works for me and gives me accurate result but tell me if anything is wrong!

nowarzz commented 3 years ago

I have tried this branch and it worked