search

marmarachain / marmara

This is the main repository for Marmara Credit Loops Smartchain containing the open source CC Files.
https://marmara.io/
Other
16 stars 9 forks source link

S7 NN update #39

Closed Aklix closed 1 year ago

Aklix commented 1 year ago

fixes #37

dimxy commented 1 year ago

I see that we also added a deprecation height in the kmd codebase, to shutdown nodes that did not upgrade. Do we not need similar in marmara?

DeckerSU commented 1 year ago

I see that we also added a deprecation height in the kmd codebase, to shutdown nodes that did not upgrade. Do we not need similar in marmara?

Current MCL block is 1773045, current DEPRECATION_HEIGHT is 3600000. I guess it's too far from current block height, so, we can leave everything as is.

Aklix commented 1 year ago

39 changed versions, what should be DEPRECATION_HEIGHT ?

dimxy commented 1 year ago

39 changed versions, what should be DEPRECATION_HEIGHT ?

As I can see the deprecation code is supported for the KMD net only, so we should not do anything for that. Let's stick with the protocol version