Broken chart after version change unpkg

marmelab / EventDrops

A time based / event series interactive visualization using d3.js

http://marmelab.com/EventDrops/

MIT License

1.24k stars 237 forks source link

Broken chart after version change unpkg #219

Closed ElenaNicoleta closed 6 years ago

ElenaNicoleta commented 6 years ago

Hi,

I was using previous version of eventDrops from unpkg (event-drops@0.3.1-alpha4). After latest release I got the following error message:

filterData.js:3 Uncaught TypeError: t.filter is not a function
    at n (filterData.js:3)
    at SVGTextElement.i (labels.js:8)
    at SVGTextElement.<anonymous> (d3.v4.min.js:2)
    at ut.each (d3.v4.min.js:2)
    at ut.text (d3.v4.min.js:2)
    at labels.js:24
    at index.js:85
    at HTMLDivElement.<anonymous> (index.js:58)
    at ut.each (d3.v4.min.js:2)
    at e (index.js:37)

How can I fix this? Can i still use event-drops@0.3.1-alpha4?

jpetitcolas commented 6 years ago

We are using semver on this repository, hence the 1.0.0 brings several breaking changes. On this case, we renamed filteredData to visibleDataInRow. I guess this is where your issue comes from. :)

For migration details, please refer to the MIGRATION-1.0.md file. If you want to get an overview of all improvements of this new version, we published a summary blog post.

ElenaNicoleta commented 6 years ago

Hi, Thank you! This issue seems to be solved now. But i have one more question for you. Some times my chart looks very strange, as in attached picture. After i clear my browser's cache, it shows up normal again. How can I change this behavior?

activity_chart

jpetitcolas commented 6 years ago

Can you check your console for errors? Without any log, it would be difficult to guess. :)

ElenaNicoleta commented 6 years ago

"Error: attribute width: A negative value is not valid. ("-160")" this is the only one i have in console

jpetitcolas commented 6 years ago

Can you ensure the root div has correct width? Moreover, in order to ease debugging, can you reproduce your use case in this JSFiddle?

hlaingwintunn commented 6 years ago

Hello, My chart not show correctly in angular project. Can you help me?? Console error is 'svg attribute width: A negative value is not valid. ("-20")' webp net-resizeimage

nicoleta2540 commented 6 years ago

Any update on this? Still having same issue

jpetitcolas commented 6 years ago

@nicoleta2540: it would be far faster to solve if we have access to a JSFiddle reproducing the issue. :)

hlaingwintunn commented 6 years ago

Hello, I already fixed my problem. That is not a chart problem. last time I used Eventdrop chart inside hidden Tag. This hidden tag make the chart width wrong. Thank you.

ElenaNicoleta commented 6 years ago

Hello, This issue can be closed. hlaingwintunn was right, it was not a chart problem. Thank you!