search

marmelab / EventDrops

A time based / event series interactive visualization using d3.js
http://marmelab.com/EventDrops/
MIT License
1.24k stars 237 forks source link

Fixed a bug where the bounds end text disappeared. #262

Closed Busteren closed 5 years ago

Busteren commented 5 years ago

See commit for details. This fixes that the end text disappeared when scrolling/zooming.

This PR closes #240

jpetitcolas commented 5 years ago

Thanks! It looks good, and it indeed fixes the issue. I'm not member of the core team anymore, but I'm sure someone like @ThieryMichel or @Kmaschta would be able to merge you. :)

fzaninotto commented 5 years ago

@jpetitcolas I've added you back as a collaborator, you should be able to merge these changes.

jpetitcolas commented 5 years ago

Thanks @fzaninotto! I'll ping you when a new version would be ready to publish on npm.

Busteren commented 5 years ago

I believe this actually fixes even more issues; When adding data, the bound used to throw an error, which I also encountered when trying to fix the bound issue. Today I had some spare time and remembered this, so I tested out adding a single data point to the data after a chart was created (which is something a lot of people have requested) and to my surprise, it worked!

Now I haven't done a lot of testing on it, but I think it would be good for other people to try it out and see if this sorts the problem. In the DEMO i just added 

repositoriesData[2].fullData.push(data2);

With a drop that was in 2019 and sure enough it showed up (Yes I tried it twice, hence two drops here):

drop_update

If so this PR should close the following issues: #247 and #246 Should also close the following PR: #248

@jpetitcolas what do you think?

Edit: only fixes part of #236