marmelab / json-graphql-server

Get a full fake GraphQL API with zero coding in less than 30 seconds.
MIT License
1.93k stars 169 forks source link

GraphiQL set up incorrectly according to docs #179

Open jaa134 opened 1 month ago

jaa134 commented 1 month ago

What you were expecting: Docs clearly say to register your express server handler at /graphql. Then GraphiQL should work once the server starts.

What happened instead: GraphiQL loads index.html, but fails to fetch schema or make requests. All requests 404 as they are directed at the wrong handler path.

Steps to reproduce:

  1. Register express server handler using /graphql as path like docs say.
  2. Build/start express server.
  3. Open GraphiQL in web browser
  4. Notice that schema cannot be fetched and queries/mutations fail.

Related code: See:

More info GraphiQL is making requests to the wrong express handler due to a misconfiguration. If I register the handler at the base express path /, then it works fine.

Environment Node

jaa134 commented 1 month ago

@djhi Related to #177

jaa134 commented 1 month ago

@djhi Why was this closed? The new GraphiQL handler is still broken.

djhi commented 1 month ago

Read too fast...

djhi commented 1 month ago

You can open PRs by the way :)

jaa134 commented 1 month ago

Doing it now! Give me 2 seconds :)

jaa134 commented 1 month ago

@djhi I seem to not have the power to make a branch. Can you give me permissions?

djhi commented 1 month ago

You have to fork the repo, make your change on your fork and you should then have a button to submit a PR :)