search

marmelab / ng-admin

Add an AngularJS admin GUI to any RESTful API
http://ng-admin-book.marmelab.com/
MIT License
3.95k stars 725 forks source link

[RFR] Fix DateField watches #1318

Closed Kmaschta closed 7 years ago

Kmaschta commented 7 years ago

Fix #1271 Fix #1305 Supersede #1317

matheo commented 7 years ago

The persisting but minor issue is that the date selector also modify the original value I guess, because when you select a date it works fine, but if you open again, it show the previous date as selected. Maybe that plugin is having the timezone difference too. This date-time stuff is quite sensible, Javascript itself needed more clarity handling these values.

Kmaschta commented 7 years ago

I agree. To be sure to sully understand you, can you open/complate an issue about that, with a simple example to reproduce it ? Thanks

matheo commented 7 years ago

I'm short of time right now, and I guess that timezone issues will arise everywhere due to the multiple String <-> Date conversion on javascript. First on the DateField plugin, then later in the DatePicker. I'm experiencing issues with a Date filter too. So, this timezone stuff is all around.

thanhbuiea commented 7 years ago

hi @Kmaschta , we still have problem with Infinite Loop due to DateField watches. I'm now on the latest version. This fix seems not to be able to resolve the bug totally. Could you please double check on it? If you need any clue or log, please let me know. Thanks. Hope to see you reply on this soon.