marmelab / ng-admin

Add an AngularJS admin GUI to any RESTful API
http://ng-admin-book.marmelab.com/
MIT License
3.95k stars 725 forks source link

[WIP] Enhance pinned filter so they can be removed #1332

Closed Phocea closed 7 years ago

Phocea commented 7 years ago

Scope

Current pinned functionality is limitative since you define a default behavior where a filter is going to be pinned to the top of a listview, but the user has no way of removing this filter if he is not interested in it.

Being able to remoe a "pinned" filter would be great if you want to implement a way for the user to save its filter preferences, and then modify them later on!

Description

I am proposing to either:

First option would make the actual form filter condition a bit more complex.

@fzaninotto , @jpetitcolas , @Kmaschta I would appreciate your opinion before to make those changes

fzaninotto commented 7 years ago

I don't think that having unpinnable filters without user preferences makes sense, and I don't want to take the path of user preferences (too big, and too far from the initial goal of ng-admin).

Besides, if all the pinned filters can be unpinnable, than the implementation is quite easy in userland, by overriding the maFilterForm template.

So this won't be added to the core.