marmelab / react-admin

A frontend Framework for single-page applications on top of REST/GraphQL APIs, using TypeScript, React and Material Design
http://marmelab.com/react-admin
MIT License
25k stars 5.26k forks source link

Migration to Material-UI@v1? #1106

Closed oliviertassinari closed 7 years ago

oliviertassinari commented 7 years ago

Hey, we have just started using this project after considering alternatives like Forest Admin. It's great! đź‘Ź The main paint point we faced so far is keeping old material-ui version v0.x work with the upcoming one v1.x.

Do you have any plan upgrading the version of Material-UI? I have started adding a migration guide for this purpose in the documentation.

djhi commented 7 years ago

Thanks!

Closing as it's a duplicate of #924.

In short, yes, but when it will be released.

Keep up the good work !

oliviertassinari commented 7 years ago

Alright you want to wait for the official release. This shouldn't take more than 6 months. Thanks for the answer :).

djhi commented 7 years ago

6 months ?! :scream: Where's the whip emote when you need it ? :stuck_out_tongue:

PS: I already tried it on another project, you did an amazing job on v1! Can't wait for the release!

oliviertassinari commented 7 years ago

@djhi Well I have already been using v1 for a year now. The thing is that we want to keep the issue flow under control, making it non-beta will mean more issue and more frustration. So, I want to wait the end of the year to release it. The v1.x has around 15% market share of the v0.x. I also want to wait having a higher figure.

djhi commented 7 years ago

Does it mean that the API won't change anymore ?

TankiLM commented 7 years ago

Hey @oliviertassinari, just curious about what made you switch from ForestAdmin to material-ui? Happy to discuss it with you!

oliviertassinari commented 7 years ago

Hi @TankiLM, I didn't switch from ForestAdmin to Material-UI. I'm a maintainer of the library. We have picked admin-on-rest over ForestAdmin for the following reasons:

  1. We find it too expensive in comparison to the alternatives. As far as we have been documenting ourselves, admin-on-rest is going to provide more or less the same value for us with a lower cost. We had to spend a day or two to wire Objection with admin-on-rest. (@djhi we use GraphQL for the customer-facing API, but support for it seems low right now, so we picked a REST generator)
  2. We have been migrating away from Sequelize to Objection. Using the database backend isn't an option. We want to maximize data consistency by using our ORM.
djhi commented 7 years ago

About GraphQL support, did you check aor-graphql ?

We still have a lot of work here, mainly on documentation but it should be usable. We implemented the demo app using the GraphCool API.

We don’t currently have any client projects using aor-gql so we haven’t battle tested yet

oliviertassinari commented 7 years ago

@djhi I have seen it. But we would rather use something battle tested :).

TankiLM commented 7 years ago

Hey @oliviertassinari Thanks for your answer.

We offer a free version with an unlimited number of activities and no restriction on the number of users which means you can use Forest without ever having to upgrade. We do offer, however, a pro plan including features aimed at larger teams and more operational intensive businesses. For more information, please refer to our pricing page

We do support Sequelize for Node.js but not objection.js which means Forest won’t be suited for your project as of now.

fzaninotto commented 7 years ago

@oliviertassinari Would your team have some dev time to allocate to admin-on-rest to help the transition?

That would really speed things up, since your people already know the 1.0 very well.

oliviertassinari commented 7 years ago

@fzaninotto It's unlikely it will happen anytime soon as I'm already pretty busy with the Material-UI issues handling. Regarding our team. We will see how well admin-on-rest covers our use cases. The more we depend on it, the more likely we will help.

fzaninotto commented 7 years ago

OK, it was worth asking ;)