marmelab / react-admin

A frontend Framework for single-page applications on top of REST/GraphQL APIs, using TypeScript, React and Material Design
http://marmelab.com/react-admin
MIT License
24.8k stars 5.22k forks source link

Fix color for BulkUpdateButton #7296

Closed friday closed 2 years ago

friday commented 2 years ago

It uses the theme's error color, because it was accidentally copied from BulkDeleteButton

To fix this you need to remove this, or change the error color to primary (maybe the latter, so user can override it?): https://github.com/marmelab/react-admin/blob/10ad4741374ef1aa7cf5a2b4d65503b1e32dea3e/packages/ra-ui-materialui/src/button/BulkUpdateWithUndoButton.tsx#L20-L35

https://github.com/marmelab/react-admin/blob/10ad4741374ef1aa7cf5a2b4d65503b1e32dea3e/packages/ra-ui-materialui/src/button/BulkUpdateWithUndoButton.tsx#L38

https://github.com/marmelab/react-admin/blob/10ad4741374ef1aa7cf5a2b4d65503b1e32dea3e/packages/ra-ui-materialui/src/button/BulkUpdateWithUndoButton.tsx#L105

djhi commented 2 years ago

Thanks for the report. Would you mind opening a pull request to fix this?

friday commented 2 years ago

Thanks for the report. Would you mind opening a pull request to fix this?

I don't have enough time to figure out how your dev setup with monorepo etc works.