marmelab / react-admin

A frontend Framework for single-page applications on top of REST/GraphQL APIs, using TypeScript, React and Material Design
http://marmelab.com/react-admin
MIT License
24.77k stars 5.22k forks source link

[v4-RC.0] Yarn installs beta.3 instead of RC.0 #7451

Closed arnaudvergnet closed 2 years ago

arnaudvergnet commented 2 years ago

What you were expecting: Specifying "react-admin": "4.0.0-RC.0" in package.json should install the 4.0.0-RC.0 for react admin and related packages (ra-ui-materialui and others).

What happened instead: Specifying "react-admin": "4.0.0-RC.0" in package.json installs the 4.0.0-RC.0 for react admin but the 4.0.0-beta.3 for related packages (ra-ui-materialui and others).

Steps to reproduce:

  1. Setup a new project
  2. Add "react-admin": "4.0.0-RC.0" in package.json
  3. Run yarn
  4. Check package.json for ra-ui-materialui

Other information:

Specifying "react-admin": "^4.0.0-RC.0" in package.json (note the ^) installs the 4.0.0-beta.3 for react admin and related packages.

In react-admin's package.json versions are written with this symbol so this is what is causing this issue.

My guess is yarn has trouble understanding the RC.0 version name. Maybe making it lowercase would help?

I also think versions should not use ~ or ^ inside of react-admin's package.json. This would ensure all components are exactly at the same version as react-admin main package.

Environment

WiXSL commented 2 years ago

Thanks. We already updated the project dependencies, but It might need a new release.

fzaninotto commented 2 years ago

I've just pushed version 4.0.0-RC.1. Can you confirm it fixes the problem?

andrico1234 commented 2 years ago

I tried installing yarn 4.0.0-RC.1, but there doesn't seem to be such a version available in the registry

WiXSL commented 2 years ago

We are checking on it. There seems to be a problem in the repo

fzaninotto commented 2 years ago

We've republished version 4.0.0-rc.0 (lowercase rc), and it seems to fix the problem on our side. Sorry for that, but I didn't know that npm was case sensitive concerning releases.

arnaudvergnet commented 2 years ago

Tried with 4.0.0-rc.0 and it fixes on my side as well.

Thanks, closing the issue.