marmelroy / FileBrowser

Finder-style iOS file browser written in Swift
MIT License
1.52k stars 219 forks source link

Support for custom file systems and remote files #24

Open MasterCarl opened 7 years ago

MasterCarl commented 7 years ago

I adapted FileBrowser for another project I'm working on, which displays a file system loaded from a JSON REST API. This is a work in progress since I still want to refactor some of my code, fix bugs and add the possibility of loading folder content asynchronously, but maybe you have some comments already. Although the high-level usage of FileBrowser didn't change, I made some extensive changes to the underlying code. If you think this changes too much, I'd be happy to maintain it as a fork.

marmelroy commented 7 years ago

Hi @MasterCarl,

Thanks for working on this. I like the concept and am intrigued by your approach.

Please let me know when you consider it "done" so I can properly review it. I had a quick look at the code and I'm not so sure about adding a third-party dependency like Alamofire. If you are only using it for the LoadingViewController please consider replacing with NSURLSession.

MasterCarl commented 7 years ago

@marmelroy I'm done for now. Feel free to review!

amosavian commented 7 years ago

@marmelroy You may consider using my library to implement remote file access, including iCloud Drive, WebDAV, Dropbox and OneDrive. https://github.com/amosavian/FileProvider