marmelroy / Localize-Swift

Swift friendly localization and i18n with in-app language switching
MIT License
3.08k stars 330 forks source link

Pods have a slight error compared to Master #133

Open osianSmith opened 5 years ago

osianSmith commented 5 years ago

Hey, Hate to really be picky but on line 98 of Localise.swift it's if let indexOfBase = availableLanguages.index(of: "Base") , excludeBase == true { But on master it is if let indexOfBase = availableLanguages.firstIndex(of: "Base") , excludeBase == true { index has been depreciated and has been replaced by firstIndex.

It's not really an issue as such but just wanted to mention just in case if there were any other discrepancies between the versions

This library is pretty awesome though and has saved me a massive amount of work getting the Welsh Langauge supported in one of my apps (customer requirement)

Thanks

Osian