search

marmelroy / PeekPop

Peek and Pop with backwards-compatibility
MIT License
1.95k stars 123 forks source link

Retain cycle #19

Closed MarcosMunoz closed 8 years ago

MarcosMunoz commented 8 years ago

There is a retain cycle that avoids to release the memory of the view controller using the PeekPop. The references to view controller and delegates inside the library should be weak.

MarcosMunoz commented 8 years ago

Also for devices < 6S the gesture should be removed from the view in the deinit, otherwise the memory of the whole control will never be released.

MrAdamBoyd commented 8 years ago

@MarcosMunoz I just submitted a pull request ( #21 ) to fix the delegates not being weak. I'm slightly confused about what you're talking about in the second comment though. Where exactly should the gesture be removed from the view?

marmelroy commented 8 years ago

Merged and released as 0.1.5. Thanks again @MrAdamBoyd.