marmelroy / PeekPop

Peek and Pop with backwards-compatibility
MIT License
1.95k stars 123 forks source link

Fixing objects immediately getting de-initialized #22

Closed MrAdamBoyd closed 8 years ago

MrAdamBoyd commented 8 years ago

Sorry about this: my retain cycle fix was causing the objects necessary to have PeekPop work to get de-initialized immediately. I didn't catch this in testing as I didn't clean the project and recompile from scratch in between me setting up my fork and submitting the pull request. Once I cleaned the project and tried to compile it again, it stopped working.

I just checked on both an device with 3D Touch and one without, and this fix makes everything work correctly on both. This should also still fix the retain cycle issue.

Once again, extremely sorry about that, I should have tested more thoroughly.

marmelroy commented 8 years ago

Oh okay. Merging.