marmelroy / PeekPop

Peek and Pop with backwards-compatibility

MIT License

1.95k stars 123 forks source link

Closed jonmadison closed 7 years ago

jonmadison commented 7 years ago

make buildable out of the box (by Swift 3 compiler) by converting + adding SWIFT_VERSION to target

jonmadison commented 7 years ago

i'm guessing it'll fail tests because of the Swift version used in CI. I'll let you determine how best to handle:)

MatrixSenpai commented 7 years ago

30 fixes this much more cleanly by actually using Swift 3 syntax

jonmadison commented 7 years ago

just saw the other pull request; closed. side note what does "actually using Swift 3 syntax" mean

MatrixSenpai commented 7 years ago

Instead of trying to tell CP to support legacy frameworks, just update the code to be compatible with Swift 3