marmelroy / PeekPop

Peek and Pop with backwards-compatibility
MIT License
1.95k stars 123 forks source link

Update to Swift 3.0, changed screenshot to viewController and lower pressure requirements #32

Open piotrtorczynski opened 7 years ago

piotrtorczynski commented 7 years ago

Hi, I would like to show you some changes in code. I was working with your library and it's fantastic, but also have some drawback.

I implemented showing viewController instead of view's screenshot to let me show viewController and it's loading action. Without this I had barely few things loaded then.

I changed the name of delegate method to suit Swift API guideline.

I saw that in normal cases the gesture you have to make to call commit action is like lying your finger on the screen, so I wanted to lower this requirement and make magic numbers smaller.

It would be nice if you could answer my questions somehow. :)

Great job 👍