Adding support for SwiftUI + bumping to iOS 13

marmelroy / PhoneNumberKit

A Swift framework for parsing, formatting and validating international phone numbers. Inspired by Google's libphonenumber.

MIT License

5.14k stars 818 forks source link

Adding support for SwiftUI + bumping to iOS 13 #711

Closed OlafAndreas closed 9 months ago

OlafAndreas commented 1 year ago

First of all, thank you for putting the effort into this project. It makes it a lot easier for people like me to implement features that requires phone numbers 🙏

Just putting this up here for everyone else to look at, and improve, decline, accept... or whatever.. thought this could benefit others 😄

🛠️

Moving some common logic into a new object => CountryCodeDataStore.
Moving data into a CountryCodeSection structure, to move some of the heavy lifting away from the views.
Moving files into folders to hopefully improve readability when browsing the project.
Adding preview of CountryCodePickerViewController.

iTarek commented 11 months ago

Why not merge this? we need SwiftUI support.

bguidolim commented 11 months ago

It still needs review and will probably be a breaking change.

You can always use the branch if you need SwiftUI support.

It's also something up to discussion if the library will keep providing UI or if it should act as phone number parser and validator only.

You can already use it with SwiftUI without this PR anyway.

iTarek commented 11 months ago

I understand, but the UI makes it easier to use, especially with a country picker. Keeping the UI is good. Also, supporting SwiftUI would be amazing. However, at the moment, I can only see the master branch. Do you have a SwiftUI branch?

github-actions[bot] commented 9 months ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.