marmelroy / PhoneNumberKit

A Swift framework for parsing, formatting and validating international phone numbers. Inspired by Google's libphonenumber.
MIT License
5.16k stars 824 forks source link

Invalid Number is getting parsed: +5763252999 #723

Closed ngup4523 closed 10 months ago

ngup4523 commented 1 year ago

New Issue Checklist

Steps to reproduce

Parse +5763252999

Expected result

Should return invalid number since Colombia(+57) always expects 10 digit number after +57 and given number is 8 digit Correct results returned from JavaScript version: _Result from isPossibleNumber(): false Result from isPossibleNumberWithReason(): TOOSHORT Note: Numbers that are not possible have type UNKNOWN, an unknown region, and are considered invalid.

Actual result

Returns valid number with numberType as fixedLine

Environment

CocoaPods

ngup4523 commented 1 year ago

@bguidolim @michaeldwilliams Cocoapods SDK(v3.7) results not matching Javascript results

ngup4523 commented 1 year ago

Can someone look into this? @bguidolim @michaeldwilliams

breferrari commented 1 year ago

@ngup4523 this is an open source repository. They're only maintainers and most probably have real jobs/lives like you, me and everyone else. Feel free to contribute and open a pull request with a fix if you need it.

michaeldwilliams commented 1 year ago

@ngup4523 why did you tag me in this? I don't work on this project. Where did you see my name anywhere that made you tag me?

bguidolim commented 1 year ago

@ngup4523 I've just tested here and it's returning invalidNumber.

ngup4523 commented 1 year ago

@ngup4523 I've just tested here and it's returning invalidNumber.

You tested in Javascript version or Cocoapods env? @bguidolim

bguidolim commented 1 year ago

I've tested using the latest code and metadata of PNK.

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.