search

marmelroy / Zip

Swift framework for zipping and unzipping files.
MIT License
2.51k stars 452 forks source link

Use @_implementationOnly imports for Minizip #192

Closed keith closed 4 years ago

keith commented 4 years ago

This allows users to use Zip with library evolution enabled, without exposing minizip to consumers since nothing from that library is ever exposed through the public API. This is a private Swift feature that makes sure that Minizip is excluded from the generated swiftinterface file. While there is some risk this could be removed / renamed in a future Swift release, it is being used by SwiftSyntax and the new swift-driver now, so it should be low risk. If it is ever removed I believe there would be another solution to this problem.

keith commented 4 years ago

Feel free to merge this sometime if you want!