search

marmistrz / QDict

This is an open source Android dictionary application which support 'stardict' format dictionaries.
https://namndev.github.io/2015-05-13-qdict/
29 stars 8 forks source link

Does not build on F-Droid #1

Closed jspricke closed 3 years ago

jspricke commented 3 years ago 
> Build command failed.
  Error while executing process /home/vagrant/android-sdk/cmake/3.6.4111459/bin/cmake with arguments {-H/home/vagrant/build/com.annie.dictionary.fork/qDict/src/main/cpp -B/home/vagrant/build/com.annie.dictionary.fork/qDict/.cxx/cmake/release/armeabi -DANDROID_ABI=armeabi -DANDROID_PLATFORM=android-17 -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/vagrant/build/com.annie.dictionary.fork/qDict/build/intermediates/cmake/release/obj/armeabi -DCMAKE_BUILD_TYPE=Release -DANDROID_NDK=/home/vagrant/android-ndk/r12b -DCMAKE_TOOLCHAIN_FILE=/home/vagrant/android-ndk/r12b/build/cmake/android.toolchain.cmake -DCMAKE_MAKE_PROGRAM=/home/vagrant/android-sdk/cmake/3.6.4111459/bin/ninja -GAndroid Gradle - Ninja -DANDROID_STL=c++_shared}
  -- Configuring incomplete, errors occurred!

  CMake Error at /home/vagrant/android-sdk/cmake/3.6.4111459/share/cmake-3.6/Modules/CMakeDetermineSystem.cmake:104 (message):
    Could not find toolchain file:
    /home/vagrant/android-ndk/r12b/build/cmake/android.toolchain.cmake
  Call Stack (most recent call first):
    CMakeLists.txt

  CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
  CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage

https://monitor.f-droid.org/builds/log/com.annie.dictionary.fork/20210415

Would be great if you could help us fix this.

marmistrz commented 3 years ago

@jspricke thanks for the report. For me fdroid build com.annie.dictionary.fork succeeds, but I realized it's not using vagrant that way. On my machine have android-ndk r22.b-1 from AUR, so maybe the NDK in the vagrant image is too old. I'll try to enable vagrant in fdroidserver and reproduce it there.

jspricke commented 3 years ago

There is no NDK specified in your metadata yaml.

jspricke commented 3 years ago

this should fix it: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/8870

marmistrz commented 3 years ago

I've already done such a change locally, but I wanted to test it with vagrant before submitting and it takes a while to download everything ;)

marmistrz commented 3 years ago

The latest build succeeded, closing this issue. Thanks for help @jspricke!