search

marmistrz / QDict

This is an open source Android dictionary application which support 'stardict' format dictionaries.
https://namndev.github.io/2015-05-13-qdict/
29 stars 8 forks source link

Fix gradle lint. #9

Closed marmistrz closed 3 years ago

marmistrz commented 3 years ago

Closes #8.

@yuhuitech would you mind reviewing this patch?

EasyVector commented 3 years ago

OK, I would love to. So I need to apply those changes and test them, right?

marmistrz commented 3 years ago

Reviewing usually means looking at the changes, trying to find any pitfalls or mistakes. I'm not sure about this StandOutWindow change because I haven't seen anything like that while using the app. It seems to be related to some service functionality of QDict but I didn't notice it either...

marmistrz commented 3 years ago

@yuhuitech any remarks regarding this change or can I merge it?

EasyVector commented 3 years ago

OK. Sorry for the late. I applied the changes you mentioned and I did not find anything wrong and my Android Studio also did not generate any fatal warning or error message. It seems good to me. :)