marmotteabbas / local_kekulejs

The local moodle plugin of the kekule set plugins.
0 stars 0 forks source link

hard-coded roleids #4

Open danmarsden opened 4 years ago

danmarsden commented 4 years ago

https://github.com/marmotteabbas/local_kekulejs/blob/master/lib.php#L94

Many sites will delete or add new roles - you cannot guaruntee that these roles will exist or if they will actually do what you think they do. You should be checking capabilities - not looking for a specific role.