search

marnen / borg-sans-mono

Droid Sans Mono Slashed + Hasklig-style ligatures!
Apache License 2.0
132 stars 1 forks source link

Add style variants #17

Open charJe opened 4 years ago

marnen commented 4 years ago

Cool, thanks! Let me see how these look and see about getting the OpenType features in there.

marnen commented 4 years ago

Also, please make sure to write a description for future pull requests.

marnen commented 4 years ago

BTW, if you want to merge the feature file yourself, you'd do it with the File | Merge Feature Info command in FontForge. Then you can update the pull request if you want.

marnen commented 4 years ago

Also, it looks like while FontForge did a decent job, it created characters (at least in the bold weight) with some self-intersecting paths. @charJe Do you want to fix those issues or shall I try to?

charJe commented 4 years ago

I wouldn't know how to detect which are the problematic characters or how to fix it, so I think it is best if you could make an attempt. In case you want to regenerate, I used embolden my 60 em.

marnen commented 4 years ago

@charJe:

I wouldn't know how to detect which are the problematic characters

Did you try Element | Validation? FontForge can even run this automatically when you try to export to TrueType.

or how to fix it

Sometimes FontForge can suggest (and even apply) fixes.

Have you read https://fontforge.org/docs/ui/dialogs/validation.html?highlight=validate ? If not, please do so (and read some of the rest of the docs).

I greatly appreciate your jumping in and helping out with this, but please take the time to gain a little more understanding of what it is that you're doing here. :)

marnen commented 4 years ago

I don't think the mechanical bold will work in quite the way it was done either. Right now, some characters (such as W) extend well beyond the 1229-unit width. That either means that we need to increase the width or redesign those characters. The latter approach is harder, but it might be the better approach for a monospaced programming font, so that the width can stay relatively constant regardless of syntax highlighting.

marnen commented 4 years ago

Wow, I like the fact that FontForge actually did a proper italic i and l. I really didn't know it would do any of that!

charJe commented 4 years ago

It didn't do i and l, I copied the bottom of Iota and connected it with the bottom. Screenshot from 2020-07-10 12-43-26 Do you think the W extends too far? This is my first time doing anything with fonts, so my apologizes for knowing next to nothing.

marnen commented 2 years ago

…anyway, I’ll review this in more detail as soon as I can. Thanks!