search

marnen / borg-sans-mono

Droid Sans Mono Slashed + Hasklig-style ligatures!
Apache License 2.0
132 stars 1 forks source link

Upload release zip to assets #19

Open SuperSandro2000 opened 2 years ago

SuperSandro2000 commented 2 years ago

When packaging fonts for a package manager it is very inconvenient if the tip is uploaded in the markdown, not the assets because the resulting URL does not contain the git tag and can't be easily updated.

https://github.com/marnen/borg-sans-mono/files/107663/BorgSansMono.ttf.zip could be https://github.com/marnen/borg-sans-mono/releases/download/v0.2.0/BorgSansMono.ttf.zip

AtilaSaraiva commented 2 years ago

I second this!

marnen commented 2 years ago

@SuperSandro2000 I don’t understand the issue here or what you’d like me to do about it. Can you be a little clearer?

SuperSandro2000 commented 2 years ago

The current download URL of the font is https://github.com/marnen/borg-sans-mono/files/107663/BorgSansMono.ttf.zip which can't be easily updated. If it would be uploaded to assets like it is done here https://github.com/cli/cli/releases it could be easily updated in package managers.

marnen commented 2 years ago

What makes it hard to update this way? How would putting the file under assets help? (I hardly ever use package managers for fonts, so I don’t understand the problem here.)

I’m not sure how to add files to assets on a release, so if you know, I’d be happy for your help on this.

SuperSandro2000 commented 2 years ago

What makes it hard to update this way?

The URL has a random number after files which would need a custom update script to get. When uploaded to assets only the last tag name is used which is already automated.

How would putting the file under assets help?

You can edit the release and add a file to assets. https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#:~:text=Optionally%2C%20to%20include%20binary%20files%20such%20as%20compiled%20programs%20in%20your%20release%2C%20drag%20and%20drop%20or%20manually%20select%20files%20in%20the%20binaries%20box.

marnen commented 2 years ago

I believe those instructions are what got me to put the files where they are today.

I’ll look again, though.

SuperSandro2000 commented 2 years ago

Then you moved the files into the wrong box. The box to upload assets is below the text box.

marnen commented 2 years ago

There were not two places to put files the last time I made a release. Perhaps this has changed.