search

marnen / middleman-breadcrumbs

Breadcrumbs helper for Middleman (http://www.middlemanapp.com)
MIT License
11 stars 12 forks source link

breaks wrap_layout #1

Closed wohanley closed 9 years ago

wohanley commented 9 years ago

Thanks for the plugin! I'm having an issue with it, though, where it seems that having it activated breaks wrap_layout. I'm not sure what's happening, exactly, but if I try to apply a nested layout to a page, it comes out blank. Minimal reproduction is here: https://github.com/wohanley/middleman-breadcrumbs-issue, where all I've done is:

  1. add middleman-breadcrumbs to the Gemfile
  2. activate :breadcrumbs in config.rb
  3. create a nested layout (source/layouts/inner.erb)
  4. use the nested layout on index.html.erb

I'm a Ruby noob so probably won't be much help fixing it, but I spent a good bit of time trying to figure out why the hell my templates weren't working and I'll just be happy to have this on the record. Cheers!

marnen commented 9 years ago

Let me see what I can figure out. I don't think I've ever used nested layouts in Middleman.

marnen commented 9 years ago

I never got back to you about this, did I? Investigating...

marnen commented 9 years ago

Reproduced. Now to figure out why...

marnen commented 9 years ago

Hmm. The rendering happens properly, but then somewhere along the way, the output doesn't get sent to the browser.

marnen commented 9 years ago

Looks like Padrino::Helpers is breaking things. Preliminary testing suggests that it's not actually necessary. If that's so, then I'll remove it from the gem and release a new version.

marnen commented 9 years ago

Fixed in v0.1.0. Let me know if you have any more problems.

wohanley commented 9 years ago

Thanks!

marnen commented 9 years ago

You're most welcome! I'm just glad someone else is using this gem. :)