search

marnen / middleman-breadcrumbs

Breadcrumbs helper for Middleman (http://www.middlemanapp.com)
MIT License
11 stars 12 forks source link

Added 2 new options #10

Closed iamphill closed 5 years ago

iamphill commented 8 years ago

:home_home determines whether to hide the homepage link or not :convert_last determines whether to convert the final page into a link

This is what was required when updating GitLab's website 😃

marnen commented 8 years ago

Thanks! I'll need tests before I can merge this.

iamphill commented 8 years ago

Thanks for the feedback (i'm no Ruby developer so thanks 😄) i'll fix it up!

marnen commented 8 years ago

@iamphill You're most welcome. Thanks for the extra features!

iamphill commented 8 years ago

@marnen Hey! Sorry for the slow response on this - been super busy!

Having troubles with the tests - it doesn't seem like any of them are currently passing?

marnen commented 8 years ago

Travis isn't set up correctly right now, but you should be able to run the tests locally.

Thanks for the new changes! I'll review shortly.

marnen commented 8 years ago

Just as a reminder, you still need to add tests before I will merge this.

iamphill commented 8 years ago

@marnen Cool thanks - i'll have a look at adding them in 😄

marnen commented 7 years ago

@iamphill Are you still interested in having this merged? If so, please add tests.

marnen commented 5 years ago

@iamphill Do you no longer want this merged?