search

marnen / middleman-breadcrumbs

Breadcrumbs helper for Middleman (http://www.middlemanapp.com)
MIT License
11 stars 12 forks source link

prepend http_prefix to links, if defined #9

Open avillafiorita opened 8 years ago

avillafiorita commented 8 years ago

I have slightly changed your code to prepend the value of :http_prefix to the generated links. If :http_prefix is not defined the gem behaves as before.

This allows to use your gem on sites deployed on a suburi.

marnen commented 8 years ago

Is this so it handles both HTTP and HTTPS links properly?

marnen commented 8 years ago

Also, please don't change the version number. I'll do that when I release the gem.

marnen commented 8 years ago

This should not be necessary at all. The URLs that this gem generates aren't full prefixed URLs; they're paths. So the browser should automatically use the same HTTP prefix as the current page. Do you have a use case where that doesn't work?

avillafiorita commented 8 years ago

I don't seem to be able to use the gem when deploying to a suburi (e.g., http://www.example.com/home). In my opinion it is because the gem generates absolute URLs, that is, it prepends a "/" to all URLs. The generated URLs, therefore, end up pointing to the wrong location if a site lives on a subdirectory.

The way I understand middleman, this is one of the reasons config[:http_prefix] can be defined in config.rb to prepend a string to the generated URLs.

Anyhow, live example of the problem I run into lives at http://gasapp.me/help-staging/admin/getting-started.html.

If there is a way to solve the issue without changing the code, even better.

marnen commented 8 years ago

I see. I will take a look at this in detail later.

Note that I will need tests before I merge this pull request.

avillafiorita commented 7 years ago

Hi - I have set the version number to 0.4.1. thanks -a

marnen commented 7 years ago

Thank you. This still needs tests, however.