marnusw / date-fns-tz

Complementary library for date-fns v2 adding IANA time zone support
MIT License
1.06k stars 116 forks source link

Missing GitHub release for the new major release #236

Closed Haraldson closed 1 year ago

Haraldson commented 1 year ago

Would’ve hoped this was in place by now, making it easier to get up to date on any breaking changes etc.

Edit: I see now that there’s a markdown file, but why not use the GitHub feature?

marnusw commented 1 year ago

It keeps it in the source code. That and legacy reasons, i.e. it's always been there. I find many projects that use one or the other approach, I doubt I'll change it.

Haraldson commented 1 year ago

Sure. But having any releases registered in the GitHub Releases feature will make those appear in the sidebar which will in turn create an expectation of releases being tracked and available there – so might as well get rid of those to keep it consistent and intuitive?

marnusw commented 1 year ago

GitHub creates releases based on version tags. The only way to prevent that is not using tags which isn't an option.

Haraldson commented 1 year ago

In my repos I manually have to create releases from tags, no automation there.

marnusw commented 1 year ago

I definitely don't do it manually. Perhaps there is some automation or setting configured I'm not aware of...