Specify date-fns 2.x - Githubissues

drewbrend commented 5 months ago

Same as https://github.com/marnusw/date-fns-tz/pull/262 but has the lockfile updated for CI to pass.

This should fix https://github.com/marnusw/date-fns-tz/issues/260 for date-fns-tz v2 which will still be an issue even when date-fns-v3 is released.

Example where this will still be an issue after v3 is supported (real scenario from my company):

shared-library-1 uses date-fns v2 and date-fns-tz v2 (sure they could upgrade, but haven't yet)
shared-library-2 uses date-fns v3 but does not use date-fns-tz or shared-library-1 so they have no issue
some-app uses shared-library-1 and shared-library-2
date-fns-tz v2 (as a dependency of shared-library-1) will attempt to use v3 because it is available and satisfies >=2.0.0
some app will throw an error despite not even using date-fns directly

Antonio-Laguna commented 4 months ago

Came to say we've been bitten by this :) Thanks for the PR @drewbrend !

drewbrend commented 4 months ago

Thanks for the approval! Do I need to do anything to have this merged and released?

abimaelmartell commented 4 months ago

Just came here to say that i was experiencing issues because of this

chrisspiegl commented 4 months ago

I am adding my support for this to be merged and released. It would be massively helpful to mark this package v2 to only install the proper date-fns v2 versions.

simPod commented 3 months ago

@marnusw please reopen #260

marnusw commented 3 months ago

v2.0.1 published.

marnusw / date-fns-tz

Specify date-fns 2.x #267