maroba / findiff

Python package for numerical derivatives and partial differential equations in any number of dimensions.
MIT License
438 stars 61 forks source link

Recent release does not accept 0 order #33

Closed vnmabus closed 3 years ago

vnmabus commented 3 years ago

As with in #32, the recent release has an assert checking that the order is positive. 0 order derivatives (that is, do not derive for that dimension) were accepted before.

My suggestion is to change the assert to check only that the order is nonnegative.

maroba commented 3 years ago

Same as #32, I didn‘t consider this use case. I‘ll change it.

maroba commented 3 years ago

Ok, I changed it, and released v0.8.7 on pypi.

vnmabus commented 3 years ago

Ok, the new version fixes this.